salesforce: move toUTF8 out to utils

[josephjclark]

It's not an operation. We should lean into the idea that all top-level functions are Operations, and everything else goes on a namespaced object (like utils.toTUF8)

[josephjclark]

@mtuchi Tempted to do this for the next major release - what do you think?

[mtuchi]

@josephjclark I think there is a dependence here, for this to work we will need to solve first
#877

[josephjclark]

I wasn't proposing to do this in common but actually that's a much better idea!

[josephjclark]

@mtuchi I've hit a problem on moving toUTF8 to common

toUTF8 depends on any-ascii, which for annoying reasons users a deferred async module load to intialise the package. What this basically means is that salesforce overrides execute to inject a loader function.

This is fine for salesforce but not possible for common.

So here are our options:

1. Only support toUTF8 in salesforce (and move it into a util)
2. Bundle a build of any-ascii into common so that we can load it properly
3. Find an alternative library to handle the transliteration

I guess my question is - have you ever needed this function outside of salesforce?

I would go with option 2 so long as you can guarantee me that this is actually useful

[mtuchi]

@josephjclark i haven't come across a use-case for toUTF8 outside salesforce adaptor, I think option 2 sounds fine but it might be a bigger task. I would suggest we go with option 1 for now since it's much cleaner and makes lot of sense to use the function like this util.toUTF8() in job code

[josephjclark]

OK cool - for the moment I'll leave this as a salesforce util function.

I am happy enough with 2 but it takes a bit more work and I'm reluctant to do it unless there's a good reason :)

Thanks for the input!