Epic: Salesforce next #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important: common 2.0 will be released before this, which exports a new http namespace. We'll need to take care to include and document that change here. |
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mtuchi
force-pushed
the
epic/salesforce
branch
from
87fe157 to
ff1081b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Restructure results for `SalesforceResultState` functions
use validatedNoDotKeys in upsert, update and create
`salesforce` Add helper for validating and format input data
…tors into epic/salesforce
|
Ok @mtuchi I think this is ready to go live. Can I ask you to:
When I get a 👍 from you I'll merge and deploy |
|
Hiya @josephjclark i have fixed couple of typo error and run integration tests. Everything is okay 👍🏽 |
mtuchi
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic PR to track Salesforce changes
tests review