Asana & GoogleSheets improvements
#495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephjclark
reviewed
Apr 3, 2024
| const numRows = response?.data?.values.length ?? 0; | ||
| console.log(`${numRows} rows retrieved.`); | ||
|
|
||
| const nextState = { ...composeNextState(state, response.data), response }; |
There was a problem hiding this comment.
I also wonder if large data arrays are double-buffered here in state.data and state.response.
This might be a difficult situation I've stumbled into 😬
There was a problem hiding this comment.
Do you mean duplicates ? or what do you mean by double-buffered ? @josephjclark
There was a problem hiding this comment.
Yeah, I mean duplicates!
There was a problem hiding this comment.
I am worried I'm creating more problems than I'm fixing here. Let's leave this as it is for now!
josephjclark
approved these changes
Apr 3, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvements for Asana and GoogleSheet adaptor driven from OpenFn/ConSoSci#204 and OpenFn/ConSoSci#206
Details
Asana
createTaskStory()funcGoogleSheets
getValues()functionbatchUpdateValues()functionexpandReference()from common/utillogErrorfunction for in-depth error logsIssues
Closes #497, #301
Review Checklist
dev only changes don't need a changeset.