Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PAT for dhis2 #897

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

PiusKariuki
Copy link

Summary

Add a high-level, single-sentence summary of what this PR changes.

Fixes #697

Details

  1. Added a personalAccessTokenField to the configuration schema for the dhis2 adaptor
  2. Added a conditional, that uses the PAT to authenticate if it id provided but defaults back to username/password if it it not

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@josephjclark
Copy link
Collaborator

Great, thank you @PiusKariuki

Before I can release this I need to generate release notes and bump version numbers.

You can help me with this by running pnpm changeset from the repo root and following the wizard to add a MINOR change.

pnpm changeset will generate a file with user-facing release notes. Check that in and push to this branch. It should be self-explanatory and it's hard to get wrong (you can always git reset --hard to undo any changes!)

@josephjclark josephjclark self-assigned this Jan 12, 2025
@josephjclark josephjclark changed the base branch from main to release/next January 14, 2025 11:51
@josephjclark josephjclark merged commit 1bee83e into OpenFn:release/next Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PAT for DHIS2
2 participants