Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghana Adaptors for Wigal SMS, NIA and BDR #945

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Ghana Adaptors for Wigal SMS, NIA and BDR #945

merged 2 commits into from
Jan 28, 2025

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Jan 28, 2025

Summary

Details

  • Add ghana-bdr adaptor

    • Add logos
    • Add get(), post() and sendBirthNotification() operation
    • Add unit test
    • Updated readme and changelog
    • mock the adaptor response if baseUrl is not provided
  • Add ghana-nia adaptor

    • Add logos
    • Add get(), post() and registerChild() operation
    • Add unit test
    • Update readme and changelog
    • mock the adaptor response if baseUrl is not provided
  • Add wigal-sms adaptor

    • Add logos
    • Add sendSMS() operation
    • Add unit test
    • Update readme and changelog
    • mock the adaptor response if baseUrl is not provided

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?. Opened an issue on marketing repo
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
    Updated changelog manually
  • Have you ticked a box under AI Usage?

* ghana-bdr demo

* add mock agent

* add streamToString

* NIA,BDR and Wigal SMS initial draft

* updated logos

* run pnpm install in  ghana-nia

* update readme

* build docs

* update baseUrl example

* add undici

* add docs, fix typo and handle errors

* clean up

* pnpm build

* add undici

* remove makeBasicAuthHeader

* update changelog

* updated to address mtuchi's comments

* format and remove unused

* update bdr logos

* nia test

* update tests for nia

* update changelog and cleanup

---------

Co-authored-by: Emmanuel Evance <[email protected]>
Co-authored-by: Taylor Downs <[email protected]>
@mtuchi mtuchi marked this pull request as ready for review January 28, 2025 07:23
@mtuchi mtuchi requested a review from hunterachieng January 28, 2025 07:29
@mtuchi mtuchi merged commit 353b6f5 into main Jan 28, 2025
2 checks passed
@mtuchi mtuchi deleted the epic/ghana branch January 28, 2025 07:36
@mtuchi
Copy link
Collaborator Author

mtuchi commented Jan 28, 2025

Thanks @taylordowns2000

@mtuchi mtuchi changed the title Ghana Adaptors for Wigal SMS, NIA and BDR (#938) Ghana Adaptors for Wigal SMS, NIA and BDR Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants