Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kobotoolbox: migrate to common2.0 #961

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Jan 30, 2025

Summary

The kobotoolbox currently uses the old http implementation with axios and there was need to update it to the current version of common being used

Fixes #695

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@hunterachieng hunterachieng changed the base branch from main to epic/kobo January 30, 2025 14:09
@hunterachieng hunterachieng marked this pull request as ready for review January 30, 2025 14:46
@hunterachieng hunterachieng marked this pull request as draft January 30, 2025 15:05
@josephjclark josephjclark marked this pull request as ready for review February 3, 2025 13:44
@josephjclark josephjclark merged commit 28fa68f into epic/kobo Feb 3, 2025
1 of 2 checks passed
@josephjclark josephjclark deleted the feature/695-kobotoolbox-common branch February 3, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

kobotoolbox: migrate to common 2.0
2 participants