Correct github reinstall button event

Fixes #1386
OpenFn · Nov 15, 2023 · 5ff0b78 · 5ff0b78
1 parent feaaca8
commit 5ff0b78
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -100,10 +100,9 @@ bearing with us as we move towards our first stable Lightning release.)
   [#1254](https://github.com/OpenFn/Lightning/issues/1254)
 - Remove foreign key from `attempts` in preparation for partitioning
   `work_orders` [#1254](https://github.com/OpenFn/Lightning/issues/1254)
-- Remove `Workflows.delete_workflow`. It is no longer in use and would
-  require modification to not leave orphaned attempts given the removal
-  of the foreign key from `attempts`.
-  [#1254](https://github.com/OpenFn/Lightning/issues/1254)
+- Remove `Workflows.delete_workflow`. It is no longer in use and would require
+  modification to not leave orphaned attempts given the removal of the foreign
+  key from `attempts`. [#1254](https://github.com/OpenFn/Lightning/issues/1254)
 
 ### Changed
 
@@ -122,6 +121,8 @@ bearing with us as we move towards our first stable Lightning release.)
   gets lost when starting a manual workorder from the inspector interface
 - Ensure that the whole edge when selected is highlighted
   [#1160](https://github.com/OpenFn/Lightning/issues/1160)
+- Fix "Reconfigure Github" button in Project Settings
+  [#1386](https://github.com/OpenFn/Lightning/issues/1386)
 
 ## [v0.9.3] - 2023-09-27
 

diff --git a/lib/lightning_web/live/project_live/delete_connection_modal.ex b/lib/lightning_web/live/project_live/delete_connection_modal.ex
@@ -6,7 +6,6 @@ defmodule LightningWeb.ProjectLive.DeleteConnectionModal do
   attr :id, :string, required: true
   attr :show, :boolean, default: false
   attr :on_cancel, JS, default: %JS{}
-  slot :inner_block, required: true
 
   def modal(assigns) do
     ~H"""

diff --git a/lib/lightning_web/live/project_live/settings.html.heex b/lib/lightning_web/live/project_live/settings.html.heex
@@ -677,39 +677,30 @@
                         <small>
                           Need to change the repository or branch?
                         </small>
-                        <button
-                          type="button"
-                          phx-click="reinstall_clip"
-                          phx-value-id={@project.id}
-                          class="my-2 text-xs text-primary-600"
-                        >
+                        <.button phx-click="reinstall_app">
                           Re-configure your Github permissions (admin access required)
-                        </button>
+                        </.button>
                       </div>
                       <div>
                         <small>
                           No longer need to sync your project?
                         </small>
-                        <button
-                          type="button"
+                        <.button
                           phx-click={
                             LightningWeb.Components.Modal.show_modal(
                               "delete_connection_modal"
                             )
                           }
                           phx-value-id={@project.id}
-                          class="my-2 text-xs text-danger-500"
                         >
                           Remove github connection
-                        </button>
+                        </.button>
                       </div>
                     </div>
                   </div>
                 </.form>
               </div>
-              <DeleteConnectionModal.modal id="delete_connection_modal">
-                <span> Here is the stuff</span>
-              </DeleteConnectionModal.modal>
+              <DeleteConnectionModal.modal id="delete_connection_modal" />
             </div>
             <div :if={!@can_install_github} class="bg-white p-4 rounded-md">
               <h6 class="font-medium text-black">