chore: start worker directly using node instead of npm exec

OpenFn · Nov 15, 2023 · eb6c81c · eb6c81c
1 parent 94f5281
commit eb6c81c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/config/dev.exs b/config/dev.exs
@@ -38,7 +38,7 @@ config :lightning, Lightning.Vault,
 
 config :lightning, Lightning.Runtime.RuntimeManager,
   start: true,
-  args: ~w(npm exec @openfn/ws-worker -- --backoff 0.5/5),
+  args: ~w(node ./node_modules/.bin/worker -- --backoff 0.5/5),
   cd: Path.expand("../assets", __DIR__)
 
 # ## SSL Support

diff --git a/lib/lightning/runtime/runtime_manager.ex b/lib/lightning/runtime/runtime_manager.ex
@@ -151,7 +151,9 @@ defmodule Lightning.Runtime.RuntimeManager do
     # to manage your NodeJs worker app, which is configured to run on port
     # 2222. Since it's not always possible to kill that app, we'll ensure it's
     # dead here in startup.
-    System.shell("kill $(lsof -n -i :2222 | grep LISTEN | awk '{print $2}')")
+    # EDIT: This is no longer needed when using: `node ./node_modules/.bin/worker`
+    # Source: https://stackoverflow.com/questions/75594758/sigterm-not-intercepted-by-the-handler-in-nodejs-app
+    # System.shell("kill $(lsof -n -i :2222 | grep LISTEN | awk '{print $2}')")
 
     config = config()
     {args, start_opts} = Keyword.pop(config, :args, [])