Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto-generate metadata in wf2 mappings and improve wf3 #60

Merged
merged 15 commits into from
Nov 6, 2024

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Oct 28, 2024

Description

  • Update wf2 to use the auto generated metadata file
  • Update wf3 to fetch use a list of form from orm-form-metadata sheet
  • Deleted get-options-map and move the logic to 2-mappings.js
  • Update spec.yam file to use file path and remove get-options-map step

Issue

@mtuchi mtuchi changed the title update mappings Use auto-generate metadata in wf2 mappings Oct 29, 2024
@mtuchi mtuchi marked this pull request as ready for review October 29, 2024 13:19
@aleksa-krolls
Copy link
Member

hey @josephjclark can we please get your feedback here? I'd like to merge this for testing later this afternoon

1 similar comment
@aleksa-krolls
Copy link
Member

hey @josephjclark can we please get your feedback here? I'd like to merge this for testing later this afternoon

@mtuchi
Copy link
Collaborator Author

mtuchi commented Nov 5, 2024

Hiya @josephjclark worked on your feedback, Please have another look

@josephjclark
Copy link

wf2 and wf3 are both modified in this PR - the title should really be changed to help with later audits

@mtuchi
Copy link
Collaborator Author

mtuchi commented Nov 6, 2024

Updated the PR title, merging this now

@mtuchi mtuchi changed the title Use auto-generate metadata in wf2 mappings Use auto-generate metadata in wf2 mappings and improve wf3 Nov 6, 2024
@mtuchi mtuchi merged commit 58b1fc1 into next-staging Nov 6, 2024
@mtuchi mtuchi deleted the 56-fetch-form-metadata branch November 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants