Speed up the pointInPolygon function. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish24
reviewed
Apr 30, 2020
| @@ -693,14 +695,14 @@ var util = { | |||
| if (((p0.y > pt.y) !== (p1.y > pt.y)) && (pt.x < (p1.x - p0.x) * (pt.y - p0.y) / (p1.y - p0.y) + p0.x)) { | |||
| inside = !inside; | |||
| } | |||
| distSq = util.distance2dToLineSquared(pt, p0, p1); | |||
| distSq = onlySign ? 1 : util.distance2dToLineSquared(pt, p0, p1); | |||
There was a problem hiding this comment.
so if onlySign is true, the function will return distSq == 1? I did not look at the entire block, just the diff.
There was a problem hiding this comment.
distSq will be 1 (because we don't care about the actual value of the distance), but the returned result will be -1 or +1 depending on the value of the inside flag.
This relies on the distanceToPolygon2D function, but we don't actually care about the distance, so skip some calculations.
manthey
force-pushed
the
speed-up-point-in-polygon
branch
from
47230f6 to
cd7dd47
Compare
aashish24
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the distanceToPolygon2D function, but we don't actually care about the distance, so skip some calculations.