cancelOnMove distance settings #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the base images to handle changes in Chrome 83.
|
@BryonLewis CI is failing because of changes in Chrome 83. I've got a PR (#1059) that fixes that particular issue. Please rebase or merge from that branch. |
…e/geojs into cancel-on-distance
manthey
reviewed
May 29, 2020
src/mapInteractor.js
Outdated
Comment on lines
27
to
29
| * @property {boolean|number} [click.cancelOnMove=true] If truthy, don't generate | ||
| * click events if the mouse moved at all. If a positive number, the distance | ||
| * at which to cancel click events when the mouse moves. |
There was a problem hiding this comment.
This should be changed to If `true`, don't ....
|
Aside from a small change needed in the jsdocs, this looks good. I don't think we need to have any code explicitly for negative numbers. |
manthey
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancelOnMovewas modified so that it would accept a non-negative number as a distance that the mouse can be moved while held down. With cancelOnMove being true by default it was difficult to do fast selection of multiple objects. This allows the objects to have some variance when a user is moving the mouse. That variance is specified by thecancelOnMovenumber.The previous functionality of utilizing false and true should still work because all uses of cancelOnMove were truthy values. I had to add in an explicit value because mouse movements in pageX and pageY do support subpixel movements if the cancelOnMove number is less than 1 I couldn't do a basic compare of
dist<cancelOnMovebecause a distance of less than 1 would result in false.MDN PageX Doc
Only additional thing would be to handle negative numbers either by defaulting to false. They weren't handled or I believed check for before, but it is something I can add in if it is decided to be necessary.