Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a screenshot button in the examples header. #669

Merged
merged 4 commits into from
Mar 1, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Feb 28, 2017

I don't know if we want this added to the examples, but it helps show off the feature, and is simpler than doing a proper screenshot widget. If you think it is undesirable, we can get rid of the PR.

Another way to do this is to just show a save dialog with the screenshot (and not show a thumbnail of it). In this version you can right-click on the image and copy it instead of being forced to download it.

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #669 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   90.63%   90.64%   +0.01%     
==========================================
  Files          84       84              
  Lines        8725     8736      +11     
==========================================
+ Hits         7908     7919      +11     
  Misses        817      817
Impacted Files Coverage Δ
src/map.js 98.78% <100%> (+0.01%)
src/util/init.js 84.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd8e05...e825e7b. Read the comment docs.

@jbeezley
Copy link
Contributor

I think the feature is okay. Just a couple minor notes:

  1. The button shouldn't appear in the header on the main examples page.
  2. It should use a different pointer when mousing over the element.

manthey added 2 commits March 1, 2017 08:23
Show the correct cursor on the screenshot button.

Fix handling screenshots of maps with background colors.
@manthey manthey merged commit 250948d into master Mar 1, 2017
@manthey manthey deleted the screenshot-in-examples branch March 1, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants