Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of node used in travis. #679

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Mar 15, 2017

Some of our node packages now require a newer version of node, so make travis use it. Our docs show us using version 4, so switch to that.

Also, relax speed test requirements to make it easier to pass on travis.

Some of our node packages now require a newer version of node, so make travis use it.  Our docs show us using version 4, so switch to that.

Also, relax speed test requirements to make it easier to pass on travis.
@aashish24
Copy link
Member

@manthey I did it on my #676 but I can take out the node version bump thanks for the fixes..

@aashish24
Copy link
Member

LGTM +2 if it passes on travis (/pr is pending). Once this goes to master, I can update my #676

@manthey manthey merged commit a210c07 into master Mar 15, 2017
@manthey manthey deleted the npm-travis-version branch March 15, 2017 17:02
@codecov-io
Copy link

Codecov Report

Merging #679 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   90.62%   90.64%   +0.02%     
==========================================
  Files          84       84              
  Lines        8736     8736              
==========================================
+ Hits         7917     7919       +2     
+ Misses        819      817       -2
Impacted Files Coverage Δ
src/mapInteractor.js 95.4% <0%> (+0.34%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8370cf...57528ad. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants