Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rows of slashes. #713

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Remove rows of slashes. #713

merged 1 commit into from
Jun 16, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jun 16, 2017

They confuse eslint.

In some instances, we used block comments of the form

///////////
// comment
///////////

These have been changed to

/*
 * comment
 */

Fixes #712.

They confuse eslint.

In some instances, we used block comments of the form
```
///////////
// comment
///////////
```
These have been changed to
```
/*
 * comment
 */
```
@manthey
Copy link
Contributor Author

manthey commented Jun 16, 2017

The eslint jsdoc warnings went from 163 to 893...

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          83       83           
  Lines        9000     9000           
=======================================
  Hits         8576     8576           
  Misses        424      424
Impacted Files Coverage Δ
src/canvas/quadFeature.js 98.41% <ø> (ø) ⬆️
src/osmLayer.js 100% <ø> (ø) ⬆️
src/heatmapFeature.js 100% <ø> (ø) ⬆️
src/pixelmapFeature.js 100% <ø> (ø) ⬆️
src/pathFeature.js 71.42% <ø> (ø) ⬆️
src/d3/lineFeature.js 100% <ø> (ø) ⬆️
src/d3/object.js 91.3% <ø> (ø) ⬆️
src/gl/contourFeature.js 100% <ø> (ø) ⬆️
src/canvas/lineFeature.js 100% <ø> (ø) ⬆️
src/transform.js 100% <ø> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235c395...3105cae. Read the comment docs.

@manthey manthey merged commit ead485f into master Jun 16, 2017
@manthey manthey deleted the remove-rows-of-slashes branch June 16, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants