Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a tutorial that acts as an editor #742

Merged
merged 3 commits into from
Oct 13, 2017
Merged

Make a tutorial that acts as an editor #742

merged 3 commits into from
Oct 13, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Oct 12, 2017

Make a tutorial that acts as an editor for easy exploration.

This is my equivalent of using a fiddle site. The code is stored as an ugly blob in the query string, so it is completely cookie and state free.

In general, any tutorial will store code in its url if 'keep=true' is added to the url when it is loaded. The editor tutorial always does this.

Allow resizing the tutorial pane.

This is my equivalent of using a fiddle site.  The code is stored as an ugly blob in the query string, so it is completely cookie and state free.

In general, any tutorial will store code in its url if 'keep=true' is added to the url when it is loaded.
@aashish24
Copy link
Member

@manthey hoping to get to review it today.

Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +2

@aashish24
Copy link
Member

I think having this is really useful for sharing purposes...

@manthey manthey merged commit d1abb04 into master Oct 13, 2017
@manthey manthey deleted the tutorial-urls branch October 13, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants