Fix running headed chrome tests with proxy. #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run headed tests on Chrome, we weren't invoking the proxy to serve tiles locally and skip serving fonts. This means that the tests were running against internet data sources, and therefore subject to the whims of connectivity and changes in OSM data. Install Google fonts via an npm package and include them as local files for the examples and tutorials. This avoids having to fetch them each time and also allows the headless tests to have them with certainty. Fixed the webpack public path for examples and tutorials.
aashish24
reviewed
Jan 5, 2018
| flags: [ | ||
| '--no-sandbox', // necessary to run tests in a docker |
There was a problem hiding this comment.
@jbeezley could you review the karma conf?
jbeezley
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run headed tests on Chrome, we weren't invoking the proxy to serve tiles locally and skip serving fonts. This means that the tests were running against internet data sources, and therefore subject to the whims of connectivity and changes in OSM data.
Install Google fonts via an npm package and include them as local files for the examples and tutorials. This avoids having to fetch them each time and also allows the headless tests to have them with certainty.
Fixed the webpack public path for examples and tutorials.