Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in pointSearch when a feature's gcs was not the default. #758

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jan 11, 2018

pointSearch gets a point in the map's interface gcs. Features' gcs defaults to the map's interface gcs. If the feature has a different gcs, some pointSearch functions did the wrong thing; this has been fixed, and the feature resolution of gcs has been slightly simplified.

`pointSearch` gets a point in the map's interface gcs.  Features' gcs
defaults to the map's interface gcs.  If the feature has a different
gcs, some pointSearch functions did the wrong thing; this has been
fixed, and the feature resolution of gcs has been slightly simplified.
@manthey
Copy link
Contributor Author

manthey commented Jan 11, 2018

This issue was discovered as I was working on editing annotations; since it is separable, it is presented as a stand-alone PR. It will be needed soon.

Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRTM pinging @jbeezley as well in case he has some input.

@manthey manthey merged commit 049ae56 into master Jan 12, 2018
@manthey manthey deleted the pointsearch-gcs branch January 12, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants