Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement tutorial page layout #809

Merged
merged 1 commit into from
Apr 13, 2018
Merged

improvement tutorial page layout #809

merged 1 commit into from
Apr 13, 2018

Conversation

matthewma7
Copy link

improvement tutorial page layout by not wrapping tutorial title text
And also update hexo version

@aashish24
Copy link
Member

@matthewma7 can you post before and after image?

@matthewma7
Copy link
Author

@aashish24
I kind of already pushed this change to the site.
But I can simulate a before and after:
Before:
image

After:
image

@matthewma7 matthewma7 force-pushed the website_tutorial_layout_improvement branch from fdc7960 to 3e4ac5e Compare April 13, 2018 20:28
aashish24
aashish24 approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthewma7 matthewma7 merged commit 0baf387 into master Apr 13, 2018
@matthewma7 matthewma7 deleted the website_tutorial_layout_improvement branch April 13, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashish24 aashish24 aashish24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewma7 @aashish24