Switch test progress to use the karma-spec-reporter. #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of printing test progress like
```
JS 2.1.1 (Linux 0.0.0): Executed 89 of 1022 SUCCESS (0 secs / 0 secs)
```
this prints information like
```
geo.annotation
geo.annotation.lineAnnotation
✓ _coordinates
```
For coverage tests, I've set it to only print failures. This will make
it easier to read through results on CI.
Also, the colorLegend test was failing when run without coverage but
passing when run with coverage. This has to do with how browsers are
invoked, and was the result of a shift the location of the map element.
This location is now used to determine where to perform a mouse test,
resulting in identical results regardless of coverage. By fixing how a
mouse event was created in PhantomJS, PhantomJS now gets identical
results to Firefox.
|
@jbeezley could you review it? |
jbeezley
approved these changes
May 30, 2018
At some point travis switched nodejs projects from usign an install step of `npm install` to `npm ci`. `npm ci` installs packages and runs their install scripts without ensuring that their dependencies have been run first. For canvas-prebuilt, this tries to run node-pre-gyp before node-pre-gyp is installed, which fails. Switching back to explicitly using `npm install` works better, and allows skipping explicitly fooling with node-pre-gyp as part of the install. Also, since `npm prune` may try to run `node-pre-gyp` as part of the process, if that failed to install, the `prune` step will fail. In this case, clear the `node_modules` directory and install anew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing test progress like
this prints information like
For coverage tests, I've set it to only print failures. This will make it easier to read through results on CI.
Also, the colorLegend test was failing when run without coverage but passing when run with coverage. This has to do with how browsers are invoked, and was the result of a shift the location of the map element. This location is now used to determine where to perform a mouse test, resulting in identical results regardless of coverage. By fixing how a mouse event was created in PhantomJS, PhantomJS now gets identical results to Firefox.