Ensure that all point position calls pass the data index. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want position to be a function that takes `(data, dataIndex)`, but in
several places we were only calling it with `(data)`. Also, data
entries don't have to be objects, so guard against that -- you can set a
point feature with data just equal to `{length: <number of points>}`,
and then generate the positions purely based on the index.
manthey
force-pushed
the
point-position-calls
branch
from
5dc8a95 to
cf5b12f
Compare
aashish24
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want position to be a function that takes
(data, dataIndex), but in several places we were only calling it with(data). Also, data entries don't have to be objects, so guard against that -- you can set a point feature with data just equal to{length: <number of points>}, and then generate the positions purely based on the index.