Added style typedefs. #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
style-spec
branch
3 times, most recently
from
5ad09a0 to
994ce52
Compare
|
@johnkit could you review it soon? |
johnkit
approved these changes
Aug 31, 2018
Moved all style specifications into jsdoc typedefs called `<class>.styleSpec`.
Remove a function that was untested and incorrect from the fileReader. Add tests for the fileReader. Rename the `jsonReader` to `geojsonReader`. An alias called `jsonReader` is maintained to not break existing code. The geojsonReader can take style defaults for points, lines, and polygons. This uses newer language features, such as the spread operator. This resolves #822. This resolves #297, though it does not add a load event. If that is still desired, a new issue should be made.
Update the fileReader and geojsonReader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all style specifications into jsdoc typedefs called
<class>.styleSpec.This also adds a link within the style function description that links to the
styleSpecof the current class (even within classes that inheritstyle). This resolves #70 and resolves #857 (for all features that have up to date documentation).