Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no ci] fix timezone.sh to write complete timezone data string #1122

Merged
merged 3 commits into from
Nov 8, 2023
Merged

[no ci] fix timezone.sh to write complete timezone data string #1122

merged 3 commits into from
Nov 8, 2023

Conversation

gtxaspec
Copy link
Contributor

@gtxaspec gtxaspec commented Nov 7, 2023 •
edited
Loading

  • Fix: timezone.sh should write the entire POSIX timezone string instead of just the timezone's short code. This will make certain that the time is set correctly on NTP sync, ensuring that the system knows both the standard offset and when to apply daylight saving adjustments.

before:

# cat /etc/TZ
PST8PDT

after:

# cat /etc/TZ
PST8PDT,M3.2.0,M11.1.0

flyrouter
flyrouter approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@flyrouter flyrouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@flyrouter flyrouter merged commit 25a2ea5 into OpenIPC:master Nov 8, 2023
96 checks passed
@gtxaspec gtxaspec deleted the timezone-script branch January 9, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyrouter flyrouter flyrouter approved these changes

@widgetii widgetii Awaiting requested review from widgetii widgetii is a code owner

@dimerr dimerr Awaiting requested review from dimerr dimerr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtxaspec @flyrouter