Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX performance java.util.TimeZone.getTimeZone(TimeZone.java:516) is synchronized #318

Merged
merged 2 commits into from
Jan 9, 2024
Merged

FIX performance java.util.TimeZone.getTimeZone(TimeZone.java:516) is synchronized #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f937720
FIX performance java.util.TimeZone.getTimeZone(TimeZone.java:516) is
vharseko Jan 9, 2024
675c1cd
workaround java.time.DateTimeException: Invalid ID for offset-based
vharseko Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion opendj-core/src/main/java/org/forgerock/opendj/ldap/GeneralizedTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package org.forgerock.opendj.ldap;

import java.time.ZoneId;
import java.util.Calendar;
import java.util.Date;
import java.util.GregorianCalendar;
Expand All @@ -25,6 +26,7 @@
import org.forgerock.i18n.LocalizedIllegalArgumentException;
import org.forgerock.util.Reject;


import static com.forgerock.opendj.ldap.CoreMessages.*;

/**
Expand Down Expand Up @@ -790,7 +792,11 @@ private static TimeZone getTimeZoneForOffset(final String value, final int start

// If we've gotten here, then it looks like a valid offset. We can
// create a time zone by using "GMT" followed by the offset.
return TimeZone.getTimeZone("GMT" + offSetStr);
try {
return TimeZone.getTimeZone(ZoneId.of("GMT"+offSetStr));
}catch (java.time.DateTimeException e) {
return TimeZone.getTimeZone("GMT"+offSetStr);
}
}

/** Lazily constructed internal representations. */
Expand Down
Loading