Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSONDecodeError for Ollama and hide LiteLLM vision support warning #1524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix JSONDecodeError for Ollama and hide LiteLLM vision support warning #1524

wants to merge 2 commits into from

Conversation

CyanideByte
Copy link
Contributor

@CyanideByte CyanideByte commented Nov 5, 2024 •
edited
Loading

Describe the changes you have made:

  • Disabled function calling for ollama which fixes "json.decoder.JSONDecodeError: Unterminated string starting at: line 1 column 2 (char 1)"
  • Hides a LiteLLM warning that the model doesn't support vision

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@CyanideByte CyanideByte mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeBirdTech MikeBirdTech MikeBirdTech approved these changes

@Notnaton Notnaton Notnaton approved these changes

Assignees

@KillianLucas KillianLucas

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@CyanideByte @Notnaton @MikeBirdTech @KillianLucas