Update interpreter.py - windows file system adjustment #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced (if/else...) the use of the readline library with pyreadline3 for Windows compatibility. readline is Unix-specific and not working with windows file system, while pyreadline3 provides similar functionality on Windows.
|
Oh, it seems to be fine if you just keep the interpreter.py like it is with " Maybe a change in poetry build / pyproject.toml would be better? |
|
Great catch @nirvor! Adding it to the |
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Sep 7, 2023
Update interpreter.py - windows file system adjustment (will add .toml after this and reinstate readline import in interpreter.py)
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Sep 15, 2023
Update interpreter.py - windows file system adjustment (will add .toml after this and reinstate readline import in interpreter.py)
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Nov 16, 2023
Update interpreter.py - windows file system adjustment (will add .toml after this and reinstate readline import in interpreter.py) Former-commit-id: 47fc0a2 Former-commit-id: cfbc32c455f8f58570e61fcd7000477cb1563baa Former-commit-id: c812410334077ea5e126962392f212143a85c598 [formerly aca7a2b057bcbc303ce115af59d5c9e5d06ae63e] Former-commit-id: cdfff3cbf2c5e6044375e0ba06118165c181a349
meslubi2021
added a commit
to Banking-and-financial-institutions/open-interpreter
that referenced
this pull request
Oct 27, 2024
Added a video example to the screenpipe tutorial in examples/screenpi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I replaced (if/else condition...) the use of the
readlinelibrary withpyreadline3bfor Windows compatibility.readlineis Unix-specific and not working with windows file system, whilepyreadline3provides similar functionality on Windows.( Maybe there are better solutions, like checking at building via poetry? Or maybe its fine for now)