Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProcessAutoBuy] bulkBuying #2948

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Mortimal
Copy link
Contributor

Ok, sorry its the last time i hope. Testers Required!

src/Misc.pm Show resolved Hide resolved
src/Misc.pm Outdated Show resolved Hide resolved
src/Misc.pm Outdated Show resolved Hide resolved
src/AI/CoreLogic.pm Outdated Show resolved Hide resolved
@Mortimal
Copy link
Contributor Author

Mortimal commented Oct 18, 2019

Or should I add possibility not to set price at all?
Should I change default number of items to 5 or 10 or 50 or 100?

@Nipodemos
Copy link
Contributor

it's good to leave the possibility to not set price
1 item per time is better

src/Misc.pm Outdated Show resolved Hide resolved
@Nipodemos
Copy link
Contributor

i just tested your PR, and when price is not set, it stills queues buyAuto, go to npc, start buy sequence, but it doesn't buy anything, and never ends buyAuto

@Mortimal
Copy link
Contributor Author

Still price not required. Fixes in if conditions.

@Nipodemos
Copy link
Contributor

Nipodemos commented Oct 25, 2019

in what server have you tested? i'm testing here in RMS and it is not working at all...
here are the block i've used:

edit: i honestly don't know what the problem is, but on master branch it is working normally

buyAuto Red Potion {
	npc payon_in01 5 49
	standpoint
	distance 5
	price 50
	minAmount 40
	maxAmount 50
	batchSize
	label
	disabled 0
}

buyAuto Yellow Potion {
	npc payon_in01 5 49
	standpoint
	distance 5
	price 550
	minAmount 40
	maxAmount 50
	batchSize
	label
	disabled 0
}

buyAuto White Potion {
	npc payon_in01 5 49
	standpoint
	distance 5
	price 1200
	minAmount 40
	maxAmount 50
	batchSize
	label
	disabled 0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants