Adding tests for versionless install

[cbridgha]

No description provided.

[cherylking]

The tests look good to me. The *Test.java files for the failing tests (with invoker.properties) will never be run though right (as we discussed in Slack). So why include them? If it is to document the expected behavior, maybe you should add a comment to them that explains they won't get run, but the build.log should contain the failure if inspected after the test is run?

One final thought...we have a postBuildHookScript cleanTest.bsh that is run after every test. Could some logic be added to that to check if the test was this specific one then look for the expected message in the build.log file (before running the clean command obviously)?

[cherylking]

One more thing...I think the new test case modules need to be added to the pom.xml in kernel-install-feature-test. And you may be able to add a specific postBuildHookScript in that pom.xml for the maven-invoker-plugin that would just apply to these tests.

[cbridgha]

I like your idea for postBuild. will try

[cherylking]

I think we are going to need to move the negative tests out of kernel-install-feature-test into their own test buckets since those are all invoked as part of that bucket. I don't think the invoker.properties are being honored when called as sub-modules of that larger bucket.

See my new PR #1831 for the negative tests. You can remove the ones you added on this PR since I duplicated them in the other PR.

[cherylking]

Hope you don't mind, but I made a change to BaseInstallFeature to look for the build.log in both locations. That way it will pass locally for you and also in the build. Not sure why the difference, but this solves the problem.