-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for versionless install #1829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good to me. The *Test.java files for the failing tests (with invoker.properties) will never be run though right (as we discussed in Slack). So why include them? If it is to document the expected behavior, maybe you should add a comment to them that explains they won't get run, but the build.log should contain the failure if inspected after the test is run?
One final thought...we have a postBuildHookScript cleanTest.bsh
that is run after every test. Could some logic be added to that to check if the test was this specific one then look for the expected message in the build.log file (before running the clean command obviously)?
One more thing...I think the new test case modules need to be added to the pom.xml in |
I like your idea for postBuild. will try |
I think we are going to need to move the negative tests out of See my new PR #1831 for the negative tests. You can remove the ones you added on this PR since I duplicated them in the other PR. |
1942f17
to
51f1c58
Compare
51f1c58
to
6691241
Compare
Look for build.log up one directory higher for nested tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you don't mind, but I made a change to BaseInstallFeature to look for the build.log in both locations. That way it will pass locally for you and also in the build. Not sure why the difference, but this solves the problem.
No description provided.