Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev content review #11

Open
3 tasks
gkwan-ibm opened this issue Jan 24, 2025 · 2 comments · May be fixed by #14
Open
3 tasks

Dev content review #11

gkwan-ibm opened this issue Jan 24, 2025 · 2 comments · May be fixed by #14
Assignees

Comments

@gkwan-ibm
Copy link
Member

  • Aggregating the entire build
    • the last paragraph "Set the basic configuration ..." is not clear.
    • should some common configuration at jar/build.gradle, war/build.gradle, and ear/build.gradle be defined at start/build.gradle?
    • the start/build.gradle contains repositories. The jar/build.gradle and ear/build.gradle still need to define repositories? Why war/build.gradle does not define repositories?
@arunvenmany-ibm
Copy link
Collaborator

arunvenmany-ibm commented Jan 28, 2025

  • the last paragraph "Set the basic configuration ..." is not clear.
    " Maybe we can change to common configuration ?"

  • should some common configuration at jar/build.gradle, war/build.gradle, and ear/build.gradle be defined at start/build.gradle?
    currently, all common are already moved to start/build.gradle

  • the start/build.gradle contains repositories. The jar/build.gradle and ear/build.gradle still need to define repositories? Why war/build.gradle does not define repositories?
    Yes, we can remove repositories defined in jar/build.gradle. But we need to keep ear/build.gradle repositories block since it has link to download liberty-gradle-plugin. War do not have need to download any additional repositories

Do you want me to make the code changes?

@gkwan-ibm
Copy link
Member Author

hi @arunvenmany-ibm

yes, would you create a PR?

@arunvenmany-ibm arunvenmany-ibm linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants