dev content review comments fixed #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
gkwan-ibm
reviewed
Jan 29, 2025
README.adoc
Outdated
| @@ -199,7 +199,7 @@ start/build.gradle | |||
| include::finish/build.gradle[] | |||
| ---- | |||
|
|
|||
| Set the [hotspot=packaging file=1]`basic configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules. | |||
| Set the [hotspot=packaging file=1]`common configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules. | |||
There was a problem hiding this comment.
The whole statement "Apply ... to develop the modules." does not describe what the changes in the build.gradle file that does not contain gradle-java-plugin or any plugins. It contains the java and repositories configurations.
There was a problem hiding this comment.
when you specify apply plugin: 'java' , its actually gradle-java-plugin
Modified the description to avoid confusion
Signed-off-by: Arun Venmany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Also added java block for sourceComapatibility option, as earlier used way is being deprecated