Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev content review comments fixed #14

Open
wants to merge 4 commits into
base: draft
Choose a base branch
from
+10 −26
Open

dev content review comments fixed #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a132cbe
dev content review comments fixed
arunvenmany-ibm Jan 29, 2025
216231a
dev content review comments fixed
arunvenmany-ibm Jan 29, 2025
e75b1d5
Merge branch 'draft' into dev_content_review
gkwan-ibm Jan 29, 2025
fcb0f3e
dev content review comments fixed
arunvenmany-ibm Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ start/build.gradle
include::finish/build.gradle[]
----

Set the [hotspot=packaging file=1]`basic configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules.
Set the [hotspot=packaging file=1]`common configuration` for the project. Apply [java plugin file=1]`java plugin` and its options to all sub projects and provide repos so that any dependency can be downloaded. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules.



Expand Down
6 changes: 4 additions & 2 deletions finish/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ allprojects {
subprojects {
apply plugin: 'java'

sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}

tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8'
Expand Down
4 changes: 0 additions & 4 deletions finish/ear/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ buildscript {
}
}

repositories {
mavenLocal()
mavenCentral()
}

dependencies {
// tag::war[]
Expand Down
5 changes: 0 additions & 5 deletions finish/jar/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8'
}

repositories {
mavenLocal()
mavenCentral()
}

dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
}
Expand Down
6 changes: 4 additions & 2 deletions start/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ allprojects {
subprojects {
apply plugin: 'java'

sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}

tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8'
Expand Down
5 changes: 0 additions & 5 deletions start/ear/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ buildscript {
}
}

repositories {
mavenLocal()
mavenCentral()
}

dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
}
6 changes: 0 additions & 6 deletions start/jar/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ description = 'JAR Module'
tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8'
}

repositories {
mavenLocal()
mavenCentral()
}

dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
}
Expand Down
2 changes: 1 addition & 1 deletion start/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
rootProject.name = 'guide-gradle-multimodules'
rootProject.name = 'guide-gradle-multimodules'
Loading