Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud cli update #188

Merged
merged 34 commits into from
Jun 5, 2024
Merged

Cloud cli update #188

merged 34 commits into from
Jun 5, 2024

Conversation

Ruilin-Ma
Copy link
Contributor

@Ruilin-Ma Ruilin-Ma commented May 8, 2024

Update the command of Kubernetes cluster creation on IBM Cloud in README.adoc

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
gkwan-ibm and others added 7 commits May 28, 2024 15:48
Co-authored-by: Gilbert Kwan <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
@Ruilin-Ma
Copy link
Contributor Author

Hi @dmuelle, would you please review the changes and let me know if there is something I can help to enhance. Thanks!

Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Ruilin-Ma and others added 6 commits May 29, 2024 15:21
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Ruilin-Ma and others added 6 commits May 29, 2024 15:22
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
@Ruilin-Ma Ruilin-Ma requested a review from gkwan-ibm May 29, 2024 19:46
@Ruilin-Ma
Copy link
Contributor Author

Ruilin-Ma commented May 29, 2024

Thank you @dmuelle for your review and suggestions. Your suggestions have merged into the PR. Please let me know if the current version looks good to you. Thanks!

Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@gkwan-ibm gkwan-ibm merged commit c7f9da7 into staging Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants