-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable database rotation for Jakarta Data DDLGen testing #29968
base: integration
Are you sure you want to change the base?
Conversation
Create a common DDL Generation helper class, borrowing functionality from what already exists. Depricate individual DDL Generation helper classes.
By default the database containers we use only setup a system admin user. This test requries the use of both an admin user and database user. Also need to add a schema accessable to the database user.
fix formatting of date which put minutes where months should be, and increase the logging for tc so we can debug query strings for database containers.
#build - personal build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3a9b8ca6-b66f-4880-b9e2-11a1eb40f06c Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1ba40e29-65b1-4c5e-9a9f-2a9404ad2a7c Target locations of links might be accessible only to IBM employees. |
DB Rotation Pipeline: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=80a50c93-ba04-4f7d-9b41-32b2e27cfd6f Target locations of links might be accessible only to IBM employees. |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8C_PIJNwEe-f5vHzWaixSA Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
The build KyleAure-29968-20241026-0212 |
RTC Build: Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I spotted one minor bug in a test utility method and added a suggestion for it.
dev/fattest.simplicity/src/componenttest/topology/utils/DDLGenScript.java
Outdated
Show resolved
Hide resolved
…Script.java Co-authored-by: Nathan Rauh <[email protected]>
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8d8e89ee-32db-41cf-a10a-eb5e13232189 Target locations of links might be accessible only to IBM employees. |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FZyjsJVkEe-M9O5esDPP_g Target locations of links might be accessible only to IBM employees. |
The build KyleAure-29968-20241028-2042 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_FZyjsJVkEe-M9O5esDPP_g |
I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".
Enable DatabaseRotation for DDL Gen testing
Create a common DDL Generation helper class
Execute DDL file on servlet
Create a database user and schema on databases for testing