Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finish unit testing TCKResultInfo #29971

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from

Conversation

KyleAure
Copy link
Member

@KyleAure KyleAure commented Oct 27, 2024

Previous changes to TCKResultInfo were not fully unit tested because we had no method to mock a Liberty server.

  • Introduced mockito to the fattest.simplicity unit tests
  • Finished writing unit tests
  • Modified to the readable repeat name method to avoid duplicate seperators
    • used to return: _remove_persistence-3.1-_jpa-2.2-_jpa-2.1-_persistence-3.0_add_persistence-3.2
    • will not return: _remove_persistence-3.1-jpa-2.2-jpa-2.1-persistence-3.0_add_persistence-3.2

@KyleAure
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b91d24ef-fd86-40bb-8e06-2613092bde9f

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vACzMJSiEe-M9O5esDPP_g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@Azquelt
Copy link
Member

Azquelt commented Oct 28, 2024

For reference: this is following on from the changes in #29817

Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider renaming and documenting getReadableRepeatName()

@KyleAure
Copy link
Member Author

@Azquelt - Thanks for the feedback. I updated the method name to be getDirectoryName() because the repeat is used to construct a unique directory between repeats for runs. Let me know if that works as a good compromise.

Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks good to me, thanks.

@KyleAure
Copy link
Member Author

#build - redo personal build
#libby - check headers

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0590b28a-ddc0-4297-ba4c-7053fa49f1ca

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=95e769f5-5835-4743-89e9-af801a1ad2b1

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build KyleAure-29971-20241027-1441
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vACzMJSiEe-M9O5esDPP_g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_vACzMJSiEe-M9O5esDPP_g

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wxFmEJV-Ee-M9O5esDPP_g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • Please describe in a separate comment how you tested your changes.

  • 5 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build KyleAure-29971-20241028-1656
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wxFmEJV-Ee-M9O5esDPP_g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_wxFmEJV-Ee-M9O5esDPP_g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants