-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: finish unit testing TCKResultInfo #29971
base: integration
Are you sure you want to change the base?
Conversation
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b91d24ef-fd86-40bb-8e06-2613092bde9f Target locations of links might be accessible only to IBM employees. |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vACzMJSiEe-M9O5esDPP_g Target locations of links might be accessible only to IBM employees. |
For reference: this is following on from the changes in #29817 |
dev/fattest.simplicity/src/componenttest/topology/utils/tck/TCKResultsInfo.java
Outdated
Show resolved
Hide resolved
dev/fattest.simplicity/src/componenttest/topology/utils/tck/TCKResultsInfo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider renaming and documenting getReadableRepeatName()
@Azquelt - Thanks for the feedback. I updated the method name to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that looks good to me, thanks.
#build - redo personal build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0590b28a-ddc0-4297-ba4c-7053fa49f1ca Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=95e769f5-5835-4743-89e9-af801a1ad2b1 Target locations of links might be accessible only to IBM employees. |
The build KyleAure-29971-20241027-1441 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_vACzMJSiEe-M9O5esDPP_g |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wxFmEJV-Ee-M9O5esDPP_g Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
The build KyleAure-29971-20241028-1656 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_wxFmEJV-Ee-M9O5esDPP_g |
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Previous changes to TCKResultInfo were not fully unit tested because we had no method to mock a Liberty server.
_remove_persistence-3.1-_jpa-2.2-_jpa-2.1-_persistence-3.0_add_persistence-3.2
_remove_persistence-3.1-jpa-2.2-jpa-2.1-persistence-3.0_add_persistence-3.2