Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made necessary changes to lowercase blog and guide tags #3495

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

SteveSamJacob19
Copy link
Contributor

What was changed and why?

Tested using browser:

  • Firefox (Desktop)
  • Safari (Desktop)
  • Chrome (Desktop)

Did you test accessibility:

  • IBM Equal Access Accessibilty Checker
  • Jaws (only relevant for new UX flows)

Copy link
Contributor

@natalie-bernhard natalie-bernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch needs to be rebased onto the current prod branch. If you don't know about rebasing a branch, start with this article: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase. Let me know if you have any questions.

@natalie-bernhard
Copy link
Contributor

@steven1046 This is ready for review and has a connected PR ready for review in blogs: OpenLiberty/blogs#3455

@steven1046 steven1046 linked an issue Nov 29, 2023 that may be closed by this pull request
@steven1046
Copy link
Member

@natalie-bernhard, there are some extra accessibility changes in the commit not related to the guide/blog tags

@natalie-bernhard
Copy link
Contributor

@steven1046 Fixed

@@ -252,26 +252,26 @@ blog:
part3: feed.
tags:
announcements: announcements
MicroProfile: MicroProfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would want to change the right side value too, because that's what is shown on the site and the goal is to change the visible tags to lowercase.

Copy link
Contributor Author

@SteveSamJacob19 SteveSamJacob19 Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steven1046 Should I change it for everything then?

Copy link
Contributor

@natalie-bernhard natalie-bernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse_blog_tags.py requires updates to accommodate the new blog tags @SteveSamJacob19

@SteveSamJacob19
Copy link
Contributor Author

@natalie-bernhard @steven1046 I've made the requested changes to the yaml files and parse_blog_tags.py file.

src/main/content/blog.html Outdated Show resolved Hide resolved
@SteveSamJacob19
Copy link
Contributor Author

@steven1046 idk why those changes came up but ive fixed it now

steven1046
steven1046 previously approved these changes Dec 11, 2023
@natalie-bernhard
Copy link
Contributor

This branch requires some merging/rebasing work which we will go over together.

@SteveSamJacob19 SteveSamJacob19 merged commit 7ce591e into draft Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all tags to be lowercase, no spaces
3 participants