-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made necessary changes to lowercase blog and guide tags #3495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch needs to be rebased onto the current prod branch. If you don't know about rebasing a branch, start with this article: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase. Let me know if you have any questions.
1a88a03
to
91113e7
Compare
7eecee1
to
c1d8d63
Compare
@steven1046 This is ready for review and has a connected PR ready for review in blogs: OpenLiberty/blogs#3455 |
@natalie-bernhard, there are some extra accessibility changes in the commit not related to the guide/blog tags |
@steven1046 Fixed |
@@ -252,26 +252,26 @@ blog: | |||
part3: feed. | |||
tags: | |||
announcements: announcements | |||
MicroProfile: MicroProfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would want to change the right side value too, because that's what is shown on the site and the goal is to change the visible tags to lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steven1046 Should I change it for everything then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parse_blog_tags.py
requires updates to accommodate the new blog tags @SteveSamJacob19
458af61
to
4c538e6
Compare
@natalie-bernhard @steven1046 I've made the requested changes to the yaml files and parse_blog_tags.py file. |
@steven1046 idk why those changes came up but ive fixed it now |
This branch requires some merging/rebasing work which we will go over together. |
b9fac25
to
e897915
Compare
What was changed and why?
Tested using browser:
Did you test accessibility: