Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3471 docs toc bug #3496

Merged
merged 4 commits into from
Nov 20, 2023
Merged

3471 docs toc bug #3496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7eee26
Merge pull request #3484 from OpenLiberty/staging
natalie-bernhard Nov 15, 2023
846453e
Set node-sass version and fix feature toc jump
natalie-bernhard Nov 17, 2023
080afb3
realign with draft
natalie-bernhard Oct 17, 2023
19e633f
remove old changes
natalie-bernhard Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/build/antora_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pushd src/main/content/antora_ui
echo "Installing Antora dependencies"
npm install -g @antora/[email protected]
npm install gulp -g --ignore-scripts
npm install node-sass gulp-sass gulp-dart-sass --save-dev
npm install node-sass@7.0.3 gulp-sass gulp-dart-sass --save-dev
npm install
gulp sass:convert
SOURCEMAPS=true gulp build
Expand Down
4 changes: 2 additions & 2 deletions src/main/content/antora_ui/src/js/05-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ function selectTOC() {
if (featureToc.length > 0) {
var li = featureToc.parent()[0];
var anchor = li.querySelector(".nav-link");
navigation.activateCurrentPath(li);
navigation.scrollItemToMidpoint(anchor);
navigation.activateCurrentPath($(li));
navigation.scrollItemToMidpoint($(anchor));
}
}

Expand Down