Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed cutting of toc content in Docs #3697

Closed
wants to merge 57 commits into from
Closed

Fixed cutting of toc content in Docs #3697

wants to merge 57 commits into from

Conversation

SteveSamJacob19
Copy link
Contributor

What was changed and why?

Tested using browser:

  • Firefox (Desktop)
  • Safari (Desktop)
  • Chrome (Desktop)

Did you test accessibility:

  • IBM Equal Access Accessibilty Checker
  • Jaws (only relevant for new UX flows)

natalie-bernhard and others added 30 commits February 22, 2024 10:46
@natalie-bernhard
Merge pull request #3642 from OpenLiberty/replace-missing-commit
b740fca 
Replace missing commits
@natalie-bernhard
Merge pull request #3645 from OpenLiberty/prod
73b7a10 
Catch up commits
@natalie-bernhard
update plugin versions
c9d1909
@natalie-bernhard
Merge pull request #3658 from OpenLiberty/update-plugin-versions
afeee60 
Update plugin versions
@natalie-bernhard
Merge pull request #3660 from OpenLiberty/staging
000608a 
Update prod
@natalie-bernhard
temp downgrade plugin versions
05e6dcf
@natalie-bernhard
Merge pull request #3665 from OpenLiberty/downgrade-plugins
3d6aa66 
Downgrade plugins
@natalie-bernhard
Merge pull request #3668 from OpenLiberty/staging
926f6d4 
Update prod
@natalie-bernhard
update plugin versions
669c41c
@natalie-bernhard
temp downgrade plugin versions
5999f99
@SteveSamJacob19 @natalie-bernhard
Fixed jumping of content
4c79514
@SteveSamJacob19 @natalie-bernhard
Some edit
c87999e
@SteveSamJacob19 @natalie-bernhard
Some more edits
8e5bdd7
@SteveSamJacob19
Merge pull request #3669 from OpenLiberty/guide_bug
ead9c76 
Fixed the jumping of guide page on OS switching
@natalie-bernhard
update plugin versions
924a952
@natalie-bernhard
temp downgrade plugin versions
07eb345
@natalie-bernhard
upgrade LMP and LGP
8592059
@natalie-bernhard
Merge pull request #3673 from OpenLiberty/plugin-updates-march
260e8c8 
Plugin updates march
@natalie-bernhard
Merge pull request #3675 from OpenLiberty/staging
5e979e4 
Update prod
@natalie-bernhard
reduce feature doc files
5ce3daa
@natalie-bernhard
remove unneeded files from build
785898a
@natalie-bernhard
undo original commit changes
a5ac46e
@natalie-bernhard
upgrade OL runtime version in docker files
bcaa523
@natalie-bernhard
upgrade to newest OL version
c79632e
@natalie-bernhard
Merge pull request #3677 from OpenLiberty/reduce-build-files
9060fcd 
Reduce build files
@SteveSamJacob19
Remove twitter
40d09d0
@SteveSamJacob19
Removed more twitter
09339b7
@SteveSamJacob19
translation done
4c800ae
@natalie-bernhard
Merge pull request #3681 from OpenLiberty/staging
7cbc205 
Reduce build files; update OL version
@natalie-bernhard
Merge pull request #3679 from OpenLiberty/twitter_foot
dd1eff0 
Removed Twitter links from the entire website UI
natalie-bernhard and others added 13 commits March 25, 2024 09:43
@natalie-bernhard
Revert "Revert "Fixed jumping of content""
6c1f7c6 
This reverts commit 3307a9f.
@natalie-bernhard
Revert "Revert "Some more edits""
4df2b85 
This reverts commit a64d116.
@natalie-bernhard
Revert "Fixed jumping of content"
31357ce 
This reverts commit e1e4290.
@natalie-bernhard
Merge pull request #3683 from OpenLiberty/upgrade-jquery
103a999 
Upgrade jquery
@natalie-bernhard
Merge pull request #3685 from OpenLiberty/staging
b34891a 
Update prod
@natalie-bernhard
Merge branch 'draft' into nb-patch
56942c8
@natalie-bernhard
Merge pull request #3690 from OpenLiberty/nb-patch
09c7b3a 
Sync draft with prod
@SteveSamJacob19
Fixed cutting of doc toc
cc4b723
@natalie-bernhard
Merge pull request #3693 from OpenLiberty/doc_nav
1b50027 
Fixed cutting of docs table of contents
@SteveSamJacob19 @natalie-bernhard
Fixed interactive guide toc
d9492df
@natalie-bernhard
Merge pull request #3692 from OpenLiberty/intguide_toc
6458f04 
Fixed cutting of interactive guide toc content
@natalie-bernhard
Revert "Fixed cutting of interactive guide toc content"
eae9f8c
@natalie-bernhard
Merge pull request #3695 from OpenLiberty/revert-3692-intguide_toc
88e0c85 
Revert "Fixed cutting of interactive guide toc content"
@SteveSamJacob19 SteveSamJacob19 linked an issue Apr 3, 2024 that may be closed by this pull request
Docs table of contents cut off for very long titles #3519
Closed
natalie-bernhard
natalie-bernhard requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@natalie-bernhard natalie-bernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for the majority of the TOC, but lines under the API/SPI docs are still being cut off. Could you add a solution for that as well? I will keep these changes on draft in the meantime since they do not affect functionality.

@SteveSamJacob19 SteveSamJacob19 marked this pull request as draft April 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalie-bernhard natalie-bernhard natalie-bernhard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs table of contents cut off for very long titles
3 participants
@SteveSamJacob19 @natalie-bernhard @navaneethsnair1