Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re 4/4 I replacement #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Phosphorus551
Copy link
Contributor

Note the .blend file is for Blender 4.2

Copy link
Collaborator

@LeftofZen LeftofZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Vanilla is 1.43 tiles long, OG is 1.46 tiles long. We should make sure these are the same length as the OG versions should be 'hotswappable' and if the lengths are different, things will break.
    Other than that, everything else seems fine

@duncanspumpkin
Copy link
Contributor

  • Vanilla is 1.43 tiles long, OG is 1.46 tiles long. We should make sure these are the same length as the OG versions should be 'hotswappable' and if the lengths are different, things will break.
    Other than that, everything else seems fine

That should be fine to be different. We don't need them to be exactly the same as we are only aiming for compatibility on scenario load and there are no vehicles placed on scenario load.

@LeftofZen
Copy link
Collaborator

  • Vanilla is 1.43 tiles long, OG is 1.46 tiles long. We should make sure these are the same length as the OG versions should be 'hotswappable' and if the lengths are different, things will break.
    Other than that, everything else seems fine

That should be fine to be different. We don't need them to be exactly the same as we are only aiming for compatibility on scenario load and there are no vehicles placed on scenario load.

Fair enough, I thought it would be a bigger issue

Copy link
Collaborator

@LeftofZen LeftofZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to operate as per the vanilla version. Minor graphical differences but these are acceptable for a first pass.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants