Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade protobuf dep #204

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Downgrade protobuf dep #204

merged 2 commits into from
Oct 2, 2024

Conversation

s0l0ist
Copy link
Contributor

@s0l0ist s0l0ist commented Oct 2, 2024

Description

After installing the wheels, I noticed warnings about mismatched protobuf versions. This is because the toolchain, specifically rules_proto_grpc_python, uses a slightly older version than what we specified in the requirements.in file. This PR reintroduces a bound on the version to guarantee compatibility and remove warnings.

I've also updated my private_join_and_compute fork to remove the deprecated rules_proto in favor of protobuf and updated this repo accordingly.

Affected Dependencies

  • python protobuf==5.28.2 -> protobuf==5.27.2

How has this been tested?

  • CI

Checklist

@s0l0ist s0l0ist merged commit 3d26c4e into master Oct 2, 2024
3 of 21 checks passed
@s0l0ist s0l0ist deleted the nangelou-downgrade-protobuf branch October 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant