Skip to content

Commit

Permalink
Closes #210: Add minified option (#235)
Browse files Browse the repository at this point in the history
* Add rollup-plugin-terser option

* Do not minify function names

* Fix formatting

* update README

Co-authored-by: Oleksandr Paraska <[email protected]>
  • Loading branch information
shoniko and shoniko authored Jan 24, 2021
1 parent 08b48f2 commit 2061eb7
Show file tree
Hide file tree
Showing 4 changed files with 133 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ yarn add @openmined/syft.js @tensorflow/tfjs-core
```

If you're not using a package manager, you will be able to include Syft.js within a `<script>` tag.
In this case library classes will be available under `syft` global object.
In this case [library classes](API-REFERENCE.md) will be available under `syft` global object.

```html
<script src="https://cdn.jsdelivr.net/npm/@tensorflow/[email protected]/dist/tf.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@openmined/syft.js@latest/dist/index.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@openmined/syft.js@latest/dist/index.min.js"></script>

<script type="text/javascript">
// Create syft worker
Expand Down
119 changes: 119 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"description": "A Javascript Syft worker in the browser",
"main": "dist/index.cjs.js",
"module": "dist/index.esm.js",
"browser": "dist/index.js",
"browser": "dist/index.min.js",
"browserFull": "dist/index.js",
"files": [
"dist/*",
"*.md"
Expand Down Expand Up @@ -99,6 +100,7 @@
"rollup": "^2.22.2",
"rollup-plugin-filesize": "^9.0.2",
"rollup-plugin-peer-deps-external": "^2.2.3",
"rollup-plugin-terser": "7.0.2",
"syft-proto": "github:openmined/syft-proto#v0.4.9"
}
}
9 changes: 9 additions & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import peerDepsExternal from 'rollup-plugin-peer-deps-external';
import resolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import filesize from 'rollup-plugin-filesize';
import { terser } from 'rollup-plugin-terser';

import pkg from './package.json';

Expand All @@ -23,6 +24,14 @@ export default {
file: pkg.browser,
format: 'umd',
...sharedOutput,
// We need `keep_fnames` to not brake tensor deserialization
// See: https://github.com/OpenMined/syft.js/issues/210
plugins: [terser({ keep_fnames: true })],
},
{
file: pkg.browserFull,
format: 'umd',
...sharedOutput,
},
{
file: pkg.main,
Expand Down

0 comments on commit 2061eb7

Please sign in to comment.