Fix "empty hole" quirks #2225
Merged
Fix "empty hole" quirks #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If input data has invalid hole points, do not prepend them to the following path part, but create an empty path part instead. This prevents crashes in locations where the part end is expected to never be before path start. The empty path part might be another source of problems, but it is an artifact which is already produced by recalculateParts() (incl. the PathObject constructor).
|
This wasn't meant to be merged so quickly, but... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash fixed in GH-2224/GH-2144 had an OCD import aspect (data source) and an map editor aspect (data usage). This PR adresses the second aspect. While it was easy to locate the crash and its trigger, a confusing fact was that the path part data in the map editor wasn't the same as the data observed while debugging the OCD import. It furned out that the initial calculation of map parts in
PathObject::recalculateParts()(expected data) was overwritten byPathObject::updatePathCoords()(actual data).This PR aligns map part calulation in the second function with the first function, and a adds a basic test. This fixes the crash.
There is a certain risk that this creates new problems. But the generated data is fairly reasonable now.