Skidoo > Snowmobile renames #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s easiest if you just update en-GB and create an issue on the Localisation repo. |
|
I'll create the issue after this is merged. |
Gymnasiast
approved these changes
Feb 19, 2025
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term skidoo seems to be trademarked and primarily applies to a specific brand of snowmobiles rather than being a generic term for them. (https://ski-doo.brp.com/us/en/legal-notice.html) And also this seems like it would violate the no advertising clause or whatever it was that got some of the easter eggs and the overt six flags branding removed.
So i feel like these strings should be changed just to be on the safe side.
I have also updated en-US here, if that would be better suited in the localisation repo i can remove it from here and update it there instead. Other language strings have not been updated and some of them do seem to refer to them as skidoo so those will need to be changed too.