Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cspell to osrd-website #261

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Add cspell to osrd-website #261

merged 4 commits into from
Jan 30, 2025

Conversation

EthanPERRUZZA
Copy link
Contributor

No description provided.

@EthanPERRUZZA EthanPERRUZZA force-pushed the eth/cspell branch 2 times, most recently from 5b62c41 to 6182908 Compare January 23, 2025 13:31
@EthanPERRUZZA EthanPERRUZZA self-assigned this Jan 23, 2025
@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review January 23, 2025 13:48
@EthanPERRUZZA EthanPERRUZZA requested a review from a team as a code owner January 23, 2025 13:48
woshilapin
woshilapin reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the long and probably repetitive work 💪 I've put a few comments.

content/docs/guides/contribute/install-docker.en.md Outdated Show resolved Hide resolved
cspell/names.txt Show resolved Hide resolved
cspell/project-words.txt Show resolved Hide resolved
cspell/names.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
cspell/project-words.txt Outdated Show resolved Hide resolved
@EthanPERRUZZA
Copy link
Contributor Author

Thank you for the time you put in reviewing this PR, it isn't be funniest work either to review those type of things ahah and all your comments were completly relevant :)

woshilapin
woshilapin approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. Thank you!

@EthanPERRUZZA
docs: fix english typos
b8179fe 
Signed-off-by: Ethan Perruzza <[email protected]>
@EthanPERRUZZA
docs: fix french typos
7fba922 
Signed-off-by: Ethan Perruzza <[email protected]>
@EthanPERRUZZA
ci: add cspell check
9be45cd 
Signed-off-by: Ethan Perruzza <[email protected]>
@EthanPERRUZZA
readme: cspell command
41c7758 
Signed-off-by: Ethan Perruzza <[email protected]>
@EthanPERRUZZA EthanPERRUZZA merged commit 706082d into master Jan 30, 2025
4 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/cspell branch January 30, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElysaSrc ElysaSrc ElysaSrc approved these changes

@woshilapin woshilapin woshilapin approved these changes

Assignees

@EthanPERRUZZA EthanPERRUZZA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanPERRUZZA @woshilapin @ElysaSrc