core: stdcm: add a stop at the end to avoid signal propagation #10622
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the last post-processing simulation, the path includes the last route in full and didn't have a STOP at the end. So we'd propagate the requirements too far down. Signed-off-by: Eloi Charpentier <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10622 +/- ##
==========================================
- Coverage 81.85% 81.83% -0.02%
==========================================
Files 1075 1073 -2
Lines 107172 107058 -114
Branches 728 728
==========================================
- Hits 87726 87612 -114
Misses 19407 19407
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last post-processing simulation, the path includes the last route in full and didn't have a STOP at the end. So we'd propagate the requirements too far down.
Fix #10427 (or at least one possible cause)