Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add switch for paced train #10629

Merged
merged 1 commit into from
Feb 7, 2025
Merged

front: add switch for paced train #10629

merged 1 commit into from
Feb 7, 2025
+45 −5

Conversation

Uriel-Sautron
Copy link
Contributor

  • add a switch in user setting
  • update userSlice with pacedTrain property

close #10604

@Uriel-Sautron Uriel-Sautron self-assigned this Feb 3, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (a69c32d) to head (14fa21b).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10629   +/-   ##
=======================================
  Coverage   81.89%   81.90%           
=======================================
  Files        1079     1079           
  Lines      107441   107473   +32     
  Branches      734      734           
=======================================
+ Hits        87992    88024   +32     
  Misses      19409    19409           
  Partials       40       40
Flag Coverage Δ
editoast 74.29% <ø> (ø)
front 89.41% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/add-switch-paced-train branch from 107a3c0 to fba611b Compare February 3, 2025 16:28
@Uriel-Sautron Uriel-Sautron marked this pull request as ready for review February 3, 2025 16:28
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner February 3, 2025 16:28
theocrsb
theocrsb approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

clarani
clarani reviewed Feb 4, 2025
View reviewed changes
front/src/reducers/user/index.ts Outdated Show resolved Hide resolved
front/src/reducers/user/index.ts Show resolved Hide resolved
front/src/common/UserSettings.tsx Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron requested a review from clarani February 6, 2025 08:23
clarani
clarani reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the selector, otherwise it's fine for me

@Uriel-Sautron Uriel-Sautron force-pushed the usn/add-switch-paced-train branch from 1bfacb5 to 3222572 Compare February 6, 2025 15:32
@Uriel-Sautron Uriel-Sautron requested a review from clarani February 6, 2025 15:33
clarani
clarani approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Uriel-Sautron Uriel-Sautron force-pushed the usn/add-switch-paced-train branch from 3222572 to 22cfa2f Compare February 6, 2025 15:40
@clarani clarani enabled auto-merge February 6, 2025 15:46
@clarani clarani added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@SharglutDev SharglutDev added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@SharglutDev
Copy link
Contributor

Maybe you need to rebase 🤔

@Uriel-Sautron @Math-R
front: add switch for paced train
14fa21b 
  - add a switch in user setting
  - update userSlice with pacedTrain property

Co-authored-by: Math_R_ <[email protected]>
Signed-off-by: Uriel-Sautron <[email protected]>
@Uriel-Sautron Uriel-Sautron force-pushed the usn/add-switch-paced-train branch from 22cfa2f to 14fa21b Compare February 7, 2025 08:19
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Feb 7, 2025
Merged via the queue into dev with commit 14fa21b Feb 7, 2025
53 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/add-switch-paced-train branch February 7, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@theocrsb theocrsb theocrsb approved these changes

Assignees

@Math-R Math-R

@Uriel-Sautron Uriel-Sautron

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add switch for paced train
6 participants
@Uriel-Sautron @codecov-commenter @SharglutDev @clarani @theocrsb @Math-R