Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: move markers computation in simulation results map #10726

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 7, 2025

No description provided.

@clarani clarani self-assigned this Feb 7, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 7, 2025
@clarani clarani changed the title front: map markers in simulation results map front: move markers computation in simulation results map Feb 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (0a2b1ab) to head (966d8b8).
Report is 9 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10726      +/-   ##
==========================================
- Coverage   81.87%   81.86%   -0.01%     
==========================================
  Files        1082     1083       +1     
  Lines      107089   107103      +14     
  Branches      729      729              
==========================================
+ Hits        87676    87684       +8     
- Misses      19372    19378       +6     
  Partials       41       41              
Flag Coverage Δ
editoast 74.30% <ø> (-0.02%) ⬇️
front 89.41% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/move-map-markers-in-simulation-results-map branch from 1293a5f to 966d8b8 Compare February 12, 2025 14:59
@clarani clarani marked this pull request as ready for review February 12, 2025 14:59
@clarani clarani requested a review from a team as a code owner February 12, 2025 14:59
@clarani clarani enabled auto-merge February 12, 2025 14:59
@clarani clarani requested review from Math-R and theocrsb February 12, 2025 15:27
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice work :)

@clarani clarani added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit a808f41 Feb 13, 2025
27 checks passed
@clarani clarani deleted the cni/move-map-markers-in-simulation-results-map branch February 13, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants