Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix spelling in comments in generate_routes rs #10731

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SergeCroise
Copy link
Contributor

  • graph is therefore expanded ...

@SergeCroise SergeCroise requested a review from a team as a code owner February 7, 2025 23:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (b443b6a) to head (edb2441).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10731      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107544   107544              
  Branches      733      733              
==========================================
- Hits        88115    88109       -6     
- Misses      19390    19396       +6     
  Partials       39       39              
Flag Coverage Δ
editoast 74.38% <ø> (-0.02%) ⬇️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin
Copy link
Contributor

We're now using DCO for commits. You can take a look in https://osrd.fr/fr/docs/guides/contribute/contribute-code/commit-conventions/#le-developer-certificate-of-origin-dco for setting this up.

As for the labeler issue, we might have an issue with contributors which are not part of the OpenRailAssociation. We have a PR trying to fix that.

@Khoyo
Copy link
Contributor

Khoyo commented Feb 8, 2025

I've just enabled the repo setting Require contributors to sign off on web-based commits. It should prompt for DCO for web based commits now ;) (this will probably only be useful for new PRs though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants