-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: resilient gateway build for dev front #10732
Conversation
40fa274
to
7fd5a60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10732 +/- ##
==========================================
- Coverage 81.93% 81.93% -0.01%
==========================================
Files 1078 1078
Lines 107544 107544
Branches 733 733
==========================================
- Hits 88115 88114 -1
- Misses 19390 19391 +1
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hm, maybe we can just completely skip the front build in that case, instead of trying it and ignoring errors? |
Guess we could, no strong opinion on that. I'll let front developers go one way or another since I will not be available for this (feel free to modify the branch as you please). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7fd5a60
to
03a8c0a
Compare
Signed-off-by: Élyse Viard <[email protected]>
03a8c0a
to
271f076
Compare
@emersion I've followed what you've suggested, I will merge it so there will be less issues for developers going forward. |
When building the Gateway in development, if the front is broken we should not fail since it can happens a lot for front-end developers.
Should be tested by front-end dev to see if it fits their development workflows.