Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: resilient gateway build for dev front #10732

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Feb 8, 2025

When building the Gateway in development, if the front is broken we should not fail since it can happens a lot for front-end developers.

Should be tested by front-end dev to see if it fits their development workflows.

@ElysaSrc ElysaSrc requested a review from a team as a code owner February 8, 2025 10:59
@ElysaSrc ElysaSrc force-pushed the ev/resilient-gw-build branch from 40fa274 to 7fd5a60 Compare February 8, 2025 10:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (b443b6a) to head (271f076).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10732      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107544   107544              
  Branches      733      733              
==========================================
- Hits        88115    88114       -1     
- Misses      19390    19391       +1     
  Partials       39       39              
Flag Coverage Δ
editoast 74.39% <ø> (-0.01%) ⬇️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Feb 8, 2025

Hm, maybe we can just completely skip the front build in that case, instead of trying it and ignoring errors?

@ElysaSrc
Copy link
Member Author

ElysaSrc commented Feb 8, 2025

Hm, maybe we can just completely skip the front build in that case, instead of trying it and ignoring errors?

Guess we could, no strong opinion on that. I'll let front developers go one way or another since I will not be available for this (feel free to modify the branch as you please).

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gateway/Dockerfile Outdated Show resolved Hide resolved
@ElysaSrc ElysaSrc force-pushed the ev/resilient-gw-build branch from 7fd5a60 to 03a8c0a Compare February 8, 2025 17:38
@ElysaSrc ElysaSrc force-pushed the ev/resilient-gw-build branch from 03a8c0a to 271f076 Compare February 8, 2025 17:41
@ElysaSrc
Copy link
Member Author

ElysaSrc commented Feb 8, 2025

@emersion I've followed what you've suggested, I will merge it so there will be less issues for developers going forward.

@Khoyo Khoyo enabled auto-merge February 8, 2025 17:48
@Khoyo Khoyo added this pull request to the merge queue Feb 8, 2025
Merged via the queue into dev with commit 42f1939 Feb 8, 2025
27 checks passed
@Khoyo Khoyo deleted the ev/resilient-gw-build branch February 8, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants