Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add ETCS LoA (slowdown) tests on speed-space chart #10769

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

bougue-pe
Copy link
Contributor

Add tests on the bending points of the speed-space chart for ETCS's LoA:

  • mostly the start and end of braking
  • also one more on the point where ETCS's Guidance curve stops being used in favor of Permitted Speed curve (~236 km/h)
    image

Fixes #10495 (last test missing)

Note that safety speed and short slip speed may disappear for ETCS, but this will be a good occasion to check that it changes the tests.

@bougue-pe bougue-pe requested a review from Erashin February 11, 2025 15:56
@bougue-pe bougue-pe requested a review from a team as a code owner February 11, 2025 15:56
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.04651% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.83%. Comparing base (3f83ed4) to head (acabf78).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
tests/tests/test_train_schedule.py 86.04% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10769      +/-   ##
==========================================
- Coverage   81.83%   81.83%   -0.01%     
==========================================
  Files        1081     1081              
  Lines      106882   106957      +75     
  Branches      729      721       -8     
==========================================
+ Hits        87469    87528      +59     
- Misses      19372    19388      +16     
  Partials       41       41              
Flag Coverage Δ
editoast 74.31% <ø> (-0.02%) ⬇️
front 89.38% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.87% <86.04%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!
By the way, #10565 might just modify these values, so whomever merges first wins? :p JK, let's keep ourselves updated ;)

EDIT: Should also fail if this pr is merged: #10768

tests/tests/test_train_schedule.py Outdated Show resolved Hide resolved
tests/tests/test_train_schedule.py Outdated Show resolved Hide resolved
tests/tests/test_train_schedule.py Outdated Show resolved Hide resolved
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bougue-pe bougue-pe force-pushed the peb/tests/add_etcs_loa_integration_tests branch from 8770d7b to 14a970c Compare February 12, 2025 16:47
@bougue-pe
Copy link
Contributor Author

bougue-pe commented Feb 12, 2025

Well spotted @Erashin : I added a commit to fixup driver behavior change after rebase.

@bougue-pe bougue-pe force-pushed the peb/tests/add_etcs_loa_integration_tests branch from 14a970c to acabf78 Compare February 13, 2025 08:45
@bougue-pe bougue-pe added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit b041144 Feb 13, 2025
27 checks passed
@bougue-pe bougue-pe deleted the peb/tests/add_etcs_loa_integration_tests branch February 13, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: integration tests for ETCS EoA & LoA
4 participants