front: get rid of repetitive imports #10783
Conversation
Akctarus
force-pushed
the
tmn/front/enhance-repetitive-imports
branch
2 times, most recently
from
55a28b5 to
b9c3411
Compare
Signed-off-by: Theo Macron <[email protected]>
Akctarus
force-pushed
the
tmn/front/enhance-repetitive-imports
branch
from
b9c3411 to
864e68c
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10783 +/- ##
==========================================
- Coverage 81.83% 81.80% -0.03%
==========================================
Files 1081 1099 +18
Lines 106882 106916 +34
Branches 729 745 +16
==========================================
- Hits 87469 87467 -2
- Misses 19372 19392 +20
- Partials 41 57 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -19,7 +19,7 @@ import OPsSVGFile from 'assets/pictures/layersicons/ops.svg'; | |||
| import switchesIcon from 'assets/pictures/layersicons/switches.svg'; | |||
| import { osrdEditoastApi } from 'common/api/osrdEditoastApi'; | |||
| import { Modal } from 'common/BootstrapSNCF/ModalSNCF'; | |||
| import SwitchSNCF from 'common/BootstrapSNCF/SwitchSNCF/SwitchSNCF'; | |||
| import { SwitchSNCF } from 'common/BootstrapSNCF/SwitchSNCF'; | |||
There was a problem hiding this comment.
You can default export in SwitchSNCF/index and then:
| import { SwitchSNCF } from 'common/BootstrapSNCF/SwitchSNCF'; | |
| import SwitchSNCF from 'common/BootstrapSNCF/SwitchSNCF'; |
| @@ -0,0 +1,3 @@ | |||
| import NGE from './NGE'; | |||
|
|
|||
| export default NGE; | |||
There was a problem hiding this comment.
Maybe we can just rename NGE.tsx to index.tsx?
| import StdcmHelpModule from './StdcmHelpModule'; | ||
|
|
||
| export default StdcmHelpModule; |
There was a problem hiding this comment.
You can simply reeport default.
| import StdcmHelpModule from './StdcmHelpModule'; | |
| export default StdcmHelpModule; | |
| export { default } from './StdcmHelpModule'; |
same for all your index.ts
There was a problem hiding this comment.
Hum I'm not sure it will be a default export like this
There was a problem hiding this comment.
named reexports use as:
export { default as StdcmHelpModule } from './StdcmHelpModule'
closes #8715