core: stdcm: handle engineering allowances at low speed #10785
Merged
+112
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10785 +/- ##
==========================================
- Coverage 81.87% 81.86% -0.01%
==========================================
Files 1082 1082
Lines 107089 107119 +30
Branches 729 721 -8
==========================================
+ Hits 87676 87693 +17
- Misses 19372 19385 +13
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/handle-engineering-at-low-speed
branch
from
43a5f72 to
a76f0e2
Compare
Erashin
approved these changes
Feb 13, 2025
bougue-pe
reviewed
Feb 13, 2025
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/EngineeringAllowanceManager.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/handle-engineering-at-low-speed
branch
from
a76f0e2 to
4c81534
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low speeds would mess with the envelope operations, we'd stop before the first step